diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-01-23 15:53:45 -0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-07-30 14:10:58 +0200 |
| commit | 7562c6fb07eadc6d0d9b6643dadad3d20af4d867 (patch) | |
| tree | d966f408dddb0881ec9d8a582fc44b1dfc1d2b7b | |
| parent | fe2a2e06fd8af3a00d18691ffeb2b636f685bee4 (diff) | |
| download | lwn-7562c6fb07eadc6d0d9b6643dadad3d20af4d867.tar.gz lwn-7562c6fb07eadc6d0d9b6643dadad3d20af4d867.zip | |
drivers/mailbox/omap: make mbox->irq signed for error handling
commit 4a102b4d144f0422eb8b0a59c7cb194bf12163a9 upstream.
There is a bug in omap2_mbox_probe() where we try do:
mbox->irq = platform_get_irq(pdev, info->irq_id);
if (mbox->irq < 0) {
The problem is that mbox->irq is unsigned so the error handling doesn't
work. I've changed it to a signed integer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oliver Neukum <ONeukum@suse.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/mailbox/omap-mbox.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mailbox/omap-mbox.h b/drivers/mailbox/omap-mbox.h index 6cd38fc68599..86d7518cd13b 100644 --- a/drivers/mailbox/omap-mbox.h +++ b/drivers/mailbox/omap-mbox.h @@ -52,7 +52,7 @@ struct omap_mbox_queue { struct omap_mbox { const char *name; - unsigned int irq; + int irq; struct omap_mbox_queue *txq, *rxq; struct omap_mbox_ops *ops; struct device *dev; |