diff options
| author | Michael Chan <michael.chan@broadcom.com> | 2016-07-01 18:46:19 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-07-02 14:52:35 -0400 |
| commit | 75362a3fd4e37ff8af1ef5e3d9f2d9d5ccf2f3ab (patch) | |
| tree | da276b017d217fb2cbc259ee8b8ba1a593663c4e | |
| parent | efb15c396445644aaea9d88e68300762f01fca92 (diff) | |
| download | lwn-75362a3fd4e37ff8af1ef5e3d9f2d9d5ccf2f3ab.tar.gz lwn-75362a3fd4e37ff8af1ef5e3d9f2d9d5ccf2f3ab.zip | |
bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops.
Returning 0 for doing nothing is confusing to the user.
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index d7ab2d7982c2..c63ed2fc5b97 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -961,7 +961,7 @@ static int bnxt_set_pauseparam(struct net_device *dev, struct bnxt_link_info *link_info = &bp->link_info; if (!BNXT_SINGLE_PF(bp)) - return rc; + return -EOPNOTSUPP; if (epause->autoneg) { if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) @@ -1483,7 +1483,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata) int rc = 0; if (!BNXT_SINGLE_PF(bp)) - return 0; + return -EOPNOTSUPP; if (!(bp->flags & BNXT_FLAG_EEE_CAP)) return -EOPNOTSUPP; |