summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Cox <alan@lxorguk.ukuu.org.uk>2012-12-07 23:11:14 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-11 09:06:29 -0800
commit745a4b9a8bedb82d56e23a2e14452ab71df9cf60 (patch)
tree37e6261d4161e0461b29b6b85a2ebe8e0ce93fbb
parent6afc22ba722253aafc389264edc7134e73700e60 (diff)
downloadlwn-745a4b9a8bedb82d56e23a2e14452ab71df9cf60.tar.gz
lwn-745a4b9a8bedb82d56e23a2e14452ab71df9cf60.zip
pnpacpi: fix incorrect TEST_ALPHA() test
commit cdc87c5a30f407ed1ce43d8a22261116873d5ef1 upstream. TEST_ALPHA() is broken and always returns 0. [akpm@linux-foundation.org: return false for '@' as well, per Bjorn] Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/pnp/pnpacpi/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index e3537888db7e..291906e8e9a9 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -58,7 +58,7 @@ static inline int __init is_exclusive_device(struct acpi_device *dev)
if (!(('0' <= (c) && (c) <= '9') || ('A' <= (c) && (c) <= 'F'))) \
return 0
#define TEST_ALPHA(c) \
- if (!('@' <= (c) || (c) <= 'Z')) \
+ if (!('A' <= (c) && (c) <= 'Z')) \
return 0
static int __init ispnpidacpi(const char *id)
{