diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2024-07-18 09:52:01 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-07-31 10:43:52 -0700 |
| commit | 744ec4477b11c42e2c8de9eb8364675ae7a0bd81 (patch) | |
| tree | 5fc9ddf1626a0def4c9e28eea37832ecabaaa996 | |
| parent | 97adb1aacef8f3f3ec3363ac1f8b72db432f55f0 (diff) | |
| download | lwn-744ec4477b11c42e2c8de9eb8364675ae7a0bd81.tar.gz lwn-744ec4477b11c42e2c8de9eb8364675ae7a0bd81.zip | |
hwmon: (max16065) Fix overflows seen when writing limits
Writing large limits resulted in overflows as reported by module tests.
in0_lcrit: Suspected overflow: [max=5538, read 0, written 2147483647]
in0_crit: Suspected overflow: [max=5538, read 0, written 2147483647]
in0_min: Suspected overflow: [max=5538, read 0, written 2147483647]
Fix the problem by clamping prior to multiplications and the use of
DIV_ROUND_CLOSEST, and by using consistent variable types.
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/max16065.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/hwmon/max16065.c b/drivers/hwmon/max16065.c index 7ce9a89f93a0..5b2a174c6bad 100644 --- a/drivers/hwmon/max16065.c +++ b/drivers/hwmon/max16065.c @@ -114,9 +114,10 @@ static inline int LIMIT_TO_MV(int limit, int range) return limit * range / 256; } -static inline int MV_TO_LIMIT(int mv, int range) +static inline int MV_TO_LIMIT(unsigned long mv, int range) { - return clamp_val(DIV_ROUND_CLOSEST(mv * 256, range), 0, 255); + mv = clamp_val(mv, 0, ULONG_MAX / 256); + return DIV_ROUND_CLOSEST(clamp_val(mv * 256, 0, range * 255), range); } static inline int ADC_TO_CURR(int adc, int gain) |