diff options
| author | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-09-29 13:43:28 -0400 |
|---|---|---|
| committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-10-19 16:58:17 -0400 |
| commit | 72bf809a19d9fc97bfe39bb928149b5e0f202cb6 (patch) | |
| tree | 08368e95973c981871886d37123d34c9219296ed | |
| parent | 5fbdc10395cd500d6ff844825a918c4e6f38de37 (diff) | |
| download | lwn-72bf809a19d9fc97bfe39bb928149b5e0f202cb6.tar.gz lwn-72bf809a19d9fc97bfe39bb928149b5e0f202cb6.zip | |
xen/pciback: Do not dereference psdev during printk when it is NULL.
.. instead use BUG_ON() as all the callers of the kill_domain_by_device
check for psdev.
Suggested-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
| -rw-r--r-- | drivers/xen/xen-pciback/pci_stub.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 1b474804180a..3cc3fbe5bf8d 100644 --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -512,12 +512,7 @@ static void kill_domain_by_device(struct pcistub_device *psdev) int err; char nodename[PCI_NODENAME_MAX]; - if (!psdev) { - dev_err(&psdev->dev->dev, - "device is NULL when do AER recovery/kill_domain\n"); - return; - } - + BUG_ON(!psdev); snprintf(nodename, PCI_NODENAME_MAX, "/local/domain/0/backend/pci/%d/0", psdev->pdev->xdev->otherend_id); |