diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-07-30 11:13:52 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-05 16:34:14 -0700 |
| commit | 708fae99f656df1fade6ae9e8c1fdb3a68e78705 (patch) | |
| tree | e2399e97823797060dc1c51f15edc2ed032170a6 | |
| parent | 7d6e5a9dbeaf5788ebb9fb1471168814d7225d20 (diff) | |
| download | lwn-708fae99f656df1fade6ae9e8c1fdb3a68e78705.tar.gz lwn-708fae99f656df1fade6ae9e8c1fdb3a68e78705.zip | |
hwmon: (ads1015) Fix off-by-one for valid channel index checking
commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream.
Current code uses channel as array index, so the valid channel value is
0 .. ADS1015_CHANNELS - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 7f9dc2f86b63..22e0c926989d 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -198,7 +198,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name); |