diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 11:36:28 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-26 22:28:21 +0100 |
| commit | 6a681b61470e1daf4fd51581c21147f92fe7b75d (patch) | |
| tree | 0ef68355a91de4718616e5a1ea87bbfdd0226243 | |
| parent | 5b818fd18c7b81bb41c8a18943e562407ac95952 (diff) | |
| download | lwn-6a681b61470e1daf4fd51581c21147f92fe7b75d.tar.gz lwn-6a681b61470e1daf4fd51581c21147f92fe7b75d.zip | |
gpio: sa1100: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-sa1100.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c index 990fa9023e22..9d590166e952 100644 --- a/drivers/gpio/gpio-sa1100.c +++ b/drivers/gpio/gpio-sa1100.c @@ -17,7 +17,7 @@ static int sa1100_gpio_get(struct gpio_chip *chip, unsigned offset) { - return GPLR & GPIO_GPIO(offset); + return !!(GPLR & GPIO_GPIO(offset)); } static void sa1100_gpio_set(struct gpio_chip *chip, unsigned offset, int value) |