diff options
| author | Vignesh R <vigneshr@ti.com> | 2016-06-09 11:02:04 +0530 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2016-08-27 11:40:35 +0200 |
| commit | 68a444857c7965327f3a4ad79c0b0ddee4de2915 (patch) | |
| tree | f6e80c0a7dc53d22b827305161782e4402f6dffd | |
| parent | 3787fb664c0ce85a6205e2e852dcc6a270ae23f9 (diff) | |
| download | lwn-68a444857c7965327f3a4ad79c0b0ddee4de2915.tar.gz lwn-68a444857c7965327f3a4ad79c0b0ddee4de2915.zip | |
gpio: pca953x: Fix NBANK calculation for PCA9536
commit a246b8198f776a16d1d3a3bbfc2d437bad766b29 upstream.
NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
hence results in 0 banks for PCA9536 which has just 4 gpios. This is
wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
NBANK().
Cc: stable@vger.kernel.org
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/gpio/gpio-pca953x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 426c51dd420c..ac11e455aea5 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -75,7 +75,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id); #define MAX_BANK 5 #define BANK_SZ 8 -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ) +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ) struct pca953x_chip { unsigned gpio_start; |