diff options
| author | Colin Ian King <colin.i.king@gmail.com> | 2024-11-07 15:23:57 +0000 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2024-11-14 19:54:27 +0100 |
| commit | 67efb77cb0692ec40c416eae2dfbc70116e8ea4e (patch) | |
| tree | 5ac538dade2b852c8b0c539c3f1a5e9f1f616ce1 | |
| parent | 07593293ffabba14125c8998525adde5a832bfa3 (diff) | |
| download | lwn-67efb77cb0692ec40c416eae2dfbc70116e8ea4e.tar.gz lwn-67efb77cb0692ec40c416eae2dfbc70116e8ea4e.zip | |
mtd: ubi: remove redundant check on bytes_left at end of function
In function ubi_nvmem_reg_read the while-loop can only be exiting
of bytes_left is zero or an error has occurred. There is an exit
return path if an error occurs, so the bytes_left can only be
zero after that point. Hence the check for a non-zero bytes_left
at the end of the function is redundant and can be removed. Remove
the check and just return 0.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | drivers/mtd/ubi/nvmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/nvmem.c b/drivers/mtd/ubi/nvmem.c index a94a1a9aaec1..34f8c1d3cdee 100644 --- a/drivers/mtd/ubi/nvmem.c +++ b/drivers/mtd/ubi/nvmem.c @@ -55,7 +55,7 @@ static int ubi_nvmem_reg_read(void *priv, unsigned int from, if (err) return err; - return bytes_left == 0 ? 0 : -EIO; + return 0; } static int ubi_nvmem_add(struct ubi_volume_info *vi) |