diff options
| author | Joe Perches <joe@perches.com> | 2015-03-26 20:47:10 -0700 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-08-04 16:52:36 +0200 |
| commit | 679151c0555af3d73c3e5c53baaba6c4035085e2 (patch) | |
| tree | 413e8b425ed7bf2258d934e3efaed8b3192bb6fd | |
| parent | 1ccf9bef80418c6a505dc19bd67c7b8e1b9d2fad (diff) | |
| download | lwn-679151c0555af3d73c3e5c53baaba6c4035085e2.tar.gz lwn-679151c0555af3d73c3e5c53baaba6c4035085e2.zip | |
hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
commit a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 upstream.
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | fs/hpfs/super.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c index 3d6f8972d06e..115cb10bfd7c 100644 --- a/fs/hpfs/super.c +++ b/fs/hpfs/super.c @@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s) } /* Filesystem error... */ -static char err_buf[1024]; - void hpfs_error(struct super_block *s, const char *fmt, ...) { + struct va_format vaf; va_list args; va_start(args, fmt); - vsnprintf(err_buf, sizeof(err_buf), fmt, args); + + vaf.fmt = fmt; + vaf.va = &args; + + pr_err("filesystem error: %pV", &vaf); + va_end(args); - printk("HPFS: filesystem error: %s", err_buf); if (!hpfs_sb(s)->sb_was_error) { if (hpfs_sb(s)->sb_err == 2) { printk("; crashing the system because you wanted it\n"); |