diff options
| author | Florin Malita <fmalita@gmail.com> | 2007-03-28 22:38:55 +0200 |
|---|---|---|
| committer | Adrian Bunk <bunk@stusta.de> | 2007-03-28 22:38:55 +0200 |
| commit | 649fdb2a4ef44c1a2361e72bd4d7d9fa1b78b7df (patch) | |
| tree | da5482c47679c8ef3a3aa942866b772861acfe83 | |
| parent | 6db2121f59efe1c78c9a6dd91a6e9b718d9afe58 (diff) | |
| download | lwn-649fdb2a4ef44c1a2361e72bd4d7d9fa1b78b7df.tar.gz lwn-649fdb2a4ef44c1a2361e72bd4d7d9fa1b78b7df.zip | |
[ALSA] Dereference after free in snd_hwdep_release()
snd_card_file_remove() may free hw->card so we can't dereference
hw->card->module after that.
Coverity ID 1420.
Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
| -rw-r--r-- | sound/core/hwdep.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c index 618c43be0bc3..c3845f6eedce 100644 --- a/sound/core/hwdep.c +++ b/sound/core/hwdep.c @@ -157,6 +157,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file) { int err = -ENXIO; struct snd_hwdep *hw = file->private_data; + struct module *mod = hw->card->module; down(&hw->open_mutex); if (hw->ops.release) { err = hw->ops.release(hw, file); @@ -166,7 +167,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file) hw->used--; snd_card_file_remove(hw->card, file); up(&hw->open_mutex); - module_put(hw->card->module); + module_put(mod); return err; } |