diff options
| author | Horatiu Vultur <horatiu.vultur@microchip.com> | 2024-01-24 11:17:58 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-01-27 10:02:01 +0000 |
| commit | 62b4248105353e7d1debd30ca5c57ec5e5f28e35 (patch) | |
| tree | 8112ff03980f0866a6cc0dc27d4386a6d28364fd | |
| parent | 586e40aa883cab255ab8ddfe332c4092a5349cb7 (diff) | |
| download | lwn-62b4248105353e7d1debd30ca5c57ec5e5f28e35.tar.gz lwn-62b4248105353e7d1debd30ca5c57ec5e5f28e35.zip | |
net: lan966x: Fix port configuration when using SGMII interface
In case the interface between the MAC and the PHY is SGMII, then the bit
GIGA_MODE on the MAC side needs to be set regardless of the speed at
which it is running.
Fixes: d28d6d2e37d1 ("net: lan966x: add port module support")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/microchip/lan966x/lan966x_port.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c index 92108d354051..2e83bbb9477e 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c @@ -168,9 +168,10 @@ static void lan966x_port_link_up(struct lan966x_port *port) lan966x_taprio_speed_set(port, config->speed); /* Also the GIGA_MODE_ENA(1) needs to be set regardless of the - * port speed for QSGMII ports. + * port speed for QSGMII or SGMII ports. */ - if (phy_interface_num_ports(config->portmode) == 4) + if (phy_interface_num_ports(config->portmode) == 4 || + config->portmode == PHY_INTERFACE_MODE_SGMII) mode = DEV_MAC_MODE_CFG_GIGA_MODE_ENA_SET(1); lan_wr(config->duplex | mode, |