diff options
author | Allen Pais <apais@linux.microsoft.com> | 2024-02-27 19:10:37 +0000 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2024-02-27 09:38:26 -1000 |
commit | 60b2ebf48526567b53e0188dbd1a4df8e646bcc1 (patch) | |
tree | 3a2ab1d6fa6c0465bfd5b7d26a850641559f59b0 | |
parent | ccdec92198df0c91f45a68f971771b6b0c1ba02d (diff) | |
download | lwn-60b2ebf48526567b53e0188dbd1a4df8e646bcc1.tar.gz lwn-60b2ebf48526567b53e0188dbd1a4df8e646bcc1.zip |
workqueue: Introduce from_work() helper for cleaner callback declarations
To streamline the transition from tasklets to worqueues, a new helper
function, from_work(), is introduced. This helper, inspired by existing
from_() patterns, utilizes container_of() and eliminates the redundancy
of declaring variable types, leading to more concise and readable code.
The modified code snippet demonstrates the enhanced clarity achieved
with from_wq():
void callback(struct work_struct *w)
{
- struct some_data_structure *local = container_of(w,
struct some_data_structure,
work);
+ struct some_data_structure *local = from_work(local, w, work);
This change aims to facilitate a smoother transition and uphold code
quality standards.
Based on:
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git disable_work-v3
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | include/linux/workqueue.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 0ad534fe6673..64a60b9232d3 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h @@ -522,6 +522,9 @@ alloc_workqueue(const char *fmt, unsigned int flags, int max_active, ...); #define create_singlethread_workqueue(name) \ alloc_ordered_workqueue("%s", __WQ_LEGACY | WQ_MEM_RECLAIM, name) +#define from_work(var, callback_work, work_fieldname) \ + container_of(callback_work, typeof(*var), work_fieldname) + extern void destroy_workqueue(struct workqueue_struct *wq); struct workqueue_attrs *alloc_workqueue_attrs(void); |