diff options
| author | Jesper Dangaard Brouer <brouer@redhat.com> | 2023-05-30 16:30:41 +0200 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2023-05-31 13:08:28 +0200 |
| commit | 60548b825b082cedf89b275c21c28b1e1d030e50 (patch) | |
| tree | 714037c814933699d655f45f6f4d7f4742c5f469 | |
| parent | 9b68f30b68701e98abcec331a2cf3df972d910f8 (diff) | |
| download | lwn-60548b825b082cedf89b275c21c28b1e1d030e50.tar.gz lwn-60548b825b082cedf89b275c21c28b1e1d030e50.zip | |
samples/bpf: xdp1 and xdp2 reduce XDPBUFSIZE to 60
Default samples/pktgen scripts send 60 byte packets as hardware adds
4-bytes FCS checksum, which fulfils minimum Ethernet 64 bytes frame
size.
XDP layer will not necessary have access to the 4-bytes FCS checksum.
This leads to bpf_xdp_load_bytes() failing as it tries to copy 64-bytes
from an XDP packet that only have 60-bytes available.
Fixes: 772251742262 ("samples/bpf: fixup some tools to be able to support xdp multibuffer")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/bpf/168545704139.2996228.2516528552939485216.stgit@firesoul
| -rw-r--r-- | samples/bpf/xdp1_kern.c | 2 | ||||
| -rw-r--r-- | samples/bpf/xdp2_kern.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/samples/bpf/xdp1_kern.c b/samples/bpf/xdp1_kern.c index 0a5c704badd0..d91f27cbcfa9 100644 --- a/samples/bpf/xdp1_kern.c +++ b/samples/bpf/xdp1_kern.c @@ -39,7 +39,7 @@ static int parse_ipv6(void *data, u64 nh_off, void *data_end) return ip6h->nexthdr; } -#define XDPBUFSIZE 64 +#define XDPBUFSIZE 60 SEC("xdp.frags") int xdp_prog1(struct xdp_md *ctx) { diff --git a/samples/bpf/xdp2_kern.c b/samples/bpf/xdp2_kern.c index 67804ecf7ce3..8bca674451ed 100644 --- a/samples/bpf/xdp2_kern.c +++ b/samples/bpf/xdp2_kern.c @@ -55,7 +55,7 @@ static int parse_ipv6(void *data, u64 nh_off, void *data_end) return ip6h->nexthdr; } -#define XDPBUFSIZE 64 +#define XDPBUFSIZE 60 SEC("xdp.frags") int xdp_prog1(struct xdp_md *ctx) { |