diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-01-26 12:24:25 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-02-25 10:49:17 +0100 |
| commit | 5e903959740934e0fe34a01ce5b5511cf501d4c6 (patch) | |
| tree | 77a24c06fa89a83b2e113f50e7c6ce6126cd16a3 | |
| parent | 535f0e46f5ba30d9a84c62dc92e70cfac34938ff (diff) | |
| download | lwn-5e903959740934e0fe34a01ce5b5511cf501d4c6.tar.gz lwn-5e903959740934e0fe34a01ce5b5511cf501d4c6.zip | |
intel_scu_ipcutil: underflow in scu_reg_access()
commit b1d353ad3d5835b16724653b33c05124e1b5acf1 upstream.
"count" is controlled by the user and it can be negative. Let's prevent
that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.
Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/platform/x86/intel_scu_ipcutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index 02bc5a6343c3..aa454241489c 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -49,7 +49,7 @@ struct scu_ipc_data { static int scu_reg_access(u32 cmd, struct scu_ipc_data *data) { - int count = data->count; + unsigned int count = data->count; if (count == 0 || count == 3 || count > 4) return -EINVAL; |