diff options
| author | Damian Hobson-Garcia <dhobsong@igel.co.jp> | 2013-03-26 10:31:22 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-06-27 10:39:23 -0700 |
| commit | 5a622ab9bca8e5b2882025f7041d72a25cf70c23 (patch) | |
| tree | 2459b0ad46f2443c410b9e727f5aba9a6299198f | |
| parent | c52217e88ae0f3a4ae00562d86e338f8f85969b4 (diff) | |
| download | lwn-5a622ab9bca8e5b2882025f7041d72a25cf70c23.tar.gz lwn-5a622ab9bca8e5b2882025f7041d72a25cf70c23.zip | |
drivers: uio: Fix UIO device registration failure
commit 5ed0505c713805f89473cdc0bbfb5110dfd840cb upstream.
Until recently uio_get_minor() returned 0 for success and
a negative value on failure. This became non-negative for suceess and
negative for failure. Restore the original return value spec so that we can
successfully initialize UIO devices with a non-zero minor device
number.
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/uio/uio.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index c8b926291e28..b645c47501b4 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -374,6 +374,7 @@ static int uio_get_minor(struct uio_device *idev) retval = idr_alloc(&uio_idr, idev, 0, UIO_MAX_DEVICES, GFP_KERNEL); if (retval >= 0) { idev->minor = retval; + retval = 0; } else if (retval == -ENOSPC) { dev_err(idev->dev, "too many uio devices\n"); retval = -EINVAL; |