diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-11-08 18:22:27 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2024-11-15 19:52:51 +0800 |
| commit | 572b7cf08403b6c67dfe0dc3e0f2efb42443254f (patch) | |
| tree | 1ff030a115713afed0f47383401ae11d4ce27d09 | |
| parent | dccd55892bbbcac5b6320745c809bd310b843f2f (diff) | |
| download | lwn-572b7cf08403b6c67dfe0dc3e0f2efb42443254f.tar.gz lwn-572b7cf08403b6c67dfe0dc3e0f2efb42443254f.zip | |
crypto: cavium - Fix an error handling path in cpt_ucode_load_fw()
If do_cpt_init() fails, a previous dma_alloc_coherent() call needs to be
undone.
Add the needed dma_free_coherent() before returning.
Fixes: 9e2c7d99941d ("crypto: cavium - Add Support for Octeon-tx CPT Engine")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | drivers/crypto/cavium/cpt/cptpf_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/crypto/cavium/cpt/cptpf_main.c b/drivers/crypto/cavium/cpt/cptpf_main.c index ec17beee24c0..54de869e5374 100644 --- a/drivers/crypto/cavium/cpt/cptpf_main.c +++ b/drivers/crypto/cavium/cpt/cptpf_main.c @@ -302,6 +302,8 @@ static int cpt_ucode_load_fw(struct cpt_device *cpt, const u8 *fw, bool is_ae) ret = do_cpt_init(cpt, mcode); if (ret) { + dma_free_coherent(&cpt->pdev->dev, mcode->code_size, + mcode->code, mcode->phys_base); dev_err(dev, "do_cpt_init failed with ret: %d\n", ret); goto fw_release; } |