diff options
| author | Mark Brown <broonie@kernel.org> | 2015-11-16 13:57:37 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-12-16 12:09:35 +0000 |
| commit | 56ea1075e7f07724cf9b91039aa0968a0c70112f (patch) | |
| tree | e294e23459ac7119c774cb8350f3734036819f3b | |
| parent | 8005c49d9aea74d382f474ce11afbbc7d7130bec (diff) | |
| download | lwn-56ea1075e7f07724cf9b91039aa0968a0c70112f.tar.gz lwn-56ea1075e7f07724cf9b91039aa0968a0c70112f.zip | |
spi: spidev: Hold spi_lock over all defererences of spi in release()
We use the spi_lock spinlock to protect against races between the device
being removed and file operations on the spidev. This means that in the
removal path all references to the device need to be done under lock as
in removal we dropping references to the device.
Reported-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spidev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 91a0fcd72423..d0e7dfc647cf 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -651,11 +651,11 @@ static int spidev_release(struct inode *inode, struct file *filp) kfree(spidev->rx_buffer); spidev->rx_buffer = NULL; + spin_lock_irq(&spidev->spi_lock); if (spidev->spi) spidev->speed_hz = spidev->spi->max_speed_hz; /* ... after we unbound from the underlying device? */ - spin_lock_irq(&spidev->spi_lock); dofree = (spidev->spi == NULL); spin_unlock_irq(&spidev->spi_lock); |