diff options
| author | Philipp Stanner <pstanner@redhat.com> | 2023-09-20 14:36:10 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2023-10-09 16:59:47 +1000 |
| commit | 569c8d82f95eb5993c84fb61a649a9c4ddd208b3 (patch) | |
| tree | d8dd6433d6d37349c737238eb5b9979d48371c32 | |
| parent | 313ebe47d75558511aa1237b6e35c663b5c0ec6f (diff) | |
| download | lwn-569c8d82f95eb5993c84fb61a649a9c4ddd208b3.tar.gz lwn-569c8d82f95eb5993c84fb61a649a9c4ddd208b3.zip | |
kernel: kexec: copy user-array safely
Currently, there is no overflow-check with memdup_user().
Use the new function memdup_array_user() instead of memdup_user() for
duplicating the user-space array safely.
Suggested-by: David Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Acked-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920123612.16914-4-pstanner@redhat.com
| -rw-r--r-- | kernel/kexec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/kexec.c b/kernel/kexec.c index 107f355eac10..8f35a5a42af8 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -247,7 +247,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, ((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH_DEFAULT)) return -EINVAL; - ksegments = memdup_user(segments, nr_segments * sizeof(ksegments[0])); + ksegments = memdup_array_user(segments, nr_segments, sizeof(ksegments[0])); if (IS_ERR(ksegments)) return PTR_ERR(ksegments); |