diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-08 08:39:45 +0100 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-03-16 15:08:37 +0000 |
| commit | 541ec23c603dcb3b9cebebe40d9a68cdc89dd36b (patch) | |
| tree | 8e70072935de837cd03af9978d30224c4d3fc2b6 | |
| parent | 20c111d2e18c7318a9f2ae815c84ea0a9218317e (diff) | |
| download | lwn-541ec23c603dcb3b9cebebe40d9a68cdc89dd36b.tar.gz lwn-541ec23c603dcb3b9cebebe40d9a68cdc89dd36b.zip | |
backlight: sky81452-backlight: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-14-u.kleine-koenig@pengutronix.de
| -rw-r--r-- | drivers/video/backlight/sky81452-backlight.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c index 0172438c38ce..eb18c6eb0ff0 100644 --- a/drivers/video/backlight/sky81452-backlight.c +++ b/drivers/video/backlight/sky81452-backlight.c @@ -311,7 +311,7 @@ static int sky81452_bl_probe(struct platform_device *pdev) return ret; } -static int sky81452_bl_remove(struct platform_device *pdev) +static void sky81452_bl_remove(struct platform_device *pdev) { const struct sky81452_bl_platform_data *pdata = dev_get_platdata(&pdev->dev); @@ -325,8 +325,6 @@ static int sky81452_bl_remove(struct platform_device *pdev) if (pdata->gpiod_enable) gpiod_set_value_cansleep(pdata->gpiod_enable, 0); - - return 0; } #ifdef CONFIG_OF @@ -343,7 +341,7 @@ static struct platform_driver sky81452_bl_driver = { .of_match_table = of_match_ptr(sky81452_bl_of_match), }, .probe = sky81452_bl_probe, - .remove = sky81452_bl_remove, + .remove_new = sky81452_bl_remove, }; module_platform_driver(sky81452_bl_driver); |