diff options
| author | Florian Vaussard <florian.vaussard@epfl.ch> | 2014-04-03 14:49:25 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-03 16:21:14 -0700 |
| commit | 4fbf32a69346afc87ac1ddceb92c860d644433f9 (patch) | |
| tree | 0c45a905f66805770b886cb65d1ea304b5c69753 | |
| parent | 8f0dbfaf2715b80f491c3e23c318c4202abf89e2 (diff) | |
| download | lwn-4fbf32a69346afc87ac1ddceb92c860d644433f9.tar.gz lwn-4fbf32a69346afc87ac1ddceb92c860d644433f9.zip | |
checkpatch: fix spurious vendor compatible warnings
With a compatible string like
compatible = "foo";
checkpatch will currently try to find "foo" in vendor-prefixes.txt,
which is wrong since the vendor prefix is empty in this specific case.
Skip the vendor test if the compatible is not like
compatible = "vendor,something";
Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Joe Perches <joe@perches.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3b268b3f2362..75b587e8ddfd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2088,10 +2088,10 @@ sub process { "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr); } - my $vendor = $compat; my $vendor_path = $dt_path . "vendor-prefixes.txt"; next if (! -f $vendor_path); - $vendor =~ s/^([a-zA-Z0-9\-]+)\,.*/$1/; + next if $compat !~ /^([a-zA-Z0-9\-]+)\,/; + my $vendor = $1; `grep -Eq "$vendor" $vendor_path`; if ( $? >> 8 ) { WARN("UNDOCUMENTED_DT_STRING", |