diff options
| author | Purushothama Siddaiah <psiddaiah@mvista.com> | 2024-12-05 12:34:26 +0530 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-12-05 11:32:26 +0000 |
| commit | 4c6ac5446d060f0bf435ccc8bc3aa7b7b5f718ad (patch) | |
| tree | 1a55bfa84ca86c358b3cec45b4e4c29b84fac00c | |
| parent | ceb259e43bf572ba7d766e1679ba73861d16203a (diff) | |
| download | lwn-4c6ac5446d060f0bf435ccc8bc3aa7b7b5f718ad.tar.gz lwn-4c6ac5446d060f0bf435ccc8bc3aa7b7b5f718ad.zip | |
spi: omap2-mcspi: Fix the IS_ERR() bug for devm_clk_get_optional_enabled()
The devm_clk_get_optional_enabled() function returns error
pointers(PTR_ERR()). So use IS_ERR() to check it.
Verified on K3-J7200 EVM board, without clock node mentioned
in the device tree.
Signed-off-by: Purushothama Siddaiah <psiddaiah@mvista.com>
Reviewed-by: Corey Minyard <cminyard@mvista.com>
Link: https://patch.msgid.link/20241205070426.1861048-1-psiddaiah@mvista.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-omap2-mcspi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index e2400a067a95..add6247d3481 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -1561,10 +1561,10 @@ static int omap2_mcspi_probe(struct platform_device *pdev) } mcspi->ref_clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); - if (mcspi->ref_clk) - mcspi->ref_clk_hz = clk_get_rate(mcspi->ref_clk); - else + if (IS_ERR(mcspi->ref_clk)) mcspi->ref_clk_hz = OMAP2_MCSPI_MAX_FREQ; + else + mcspi->ref_clk_hz = clk_get_rate(mcspi->ref_clk); ctlr->max_speed_hz = mcspi->ref_clk_hz; ctlr->min_speed_hz = mcspi->ref_clk_hz >> 15; |