diff options
| author | Dave Kleikamp <dave.kleikamp@oracle.com> | 2013-09-06 21:49:56 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-11-13 12:05:31 +0900 |
| commit | 4ac4eb6520aa52f77be36780bbe5b17ca3bce983 (patch) | |
| tree | b315b84f2e10c83e3206b826a2eb01be642141a5 | |
| parent | fa2025dc177d9bef300b48289b689a5d667f5ae9 (diff) | |
| download | lwn-4ac4eb6520aa52f77be36780bbe5b17ca3bce983.tar.gz lwn-4ac4eb6520aa52f77be36780bbe5b17ca3bce983.zip | |
jfs: fix error path in ialloc
commit 8660998608cfa1077e560034db81885af8e1e885 upstream.
If insert_inode_locked() fails, we shouldn't be calling
unlock_new_inode().
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Tested-by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/jfs/jfs_inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c index c1a3e603279c..7f464c513ba0 100644 --- a/fs/jfs/jfs_inode.c +++ b/fs/jfs/jfs_inode.c @@ -95,7 +95,7 @@ struct inode *ialloc(struct inode *parent, umode_t mode) if (insert_inode_locked(inode) < 0) { rc = -EINVAL; - goto fail_unlock; + goto fail_put; } inode_init_owner(inode, parent, mode); @@ -156,7 +156,6 @@ struct inode *ialloc(struct inode *parent, umode_t mode) fail_drop: dquot_drop(inode); inode->i_flags |= S_NOQUOTA; -fail_unlock: clear_nlink(inode); unlock_new_inode(inode); fail_put: |