diff options
| author | Jes Sorensen <Jes.Sorensen@redhat.com> | 2015-10-20 12:09:12 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-11-12 14:09:03 +0100 |
| commit | 4ab46026e088c6e7801e278101d66a60ce6b72b8 (patch) | |
| tree | b962eca63469aac1ee984721c9e194d7ac487729 | |
| parent | b7775d1cd0a78e447ced2dbb41a0e1586b1cb58e (diff) | |
| download | lwn-4ab46026e088c6e7801e278101d66a60ce6b72b8.tar.gz lwn-4ab46026e088c6e7801e278101d66a60ce6b72b8.zip | |
md/raid1: submit_bio_wait() returns 0 on success
commit 203d27b0226a05202438ddb39ef0ef1acb14a759 upstream.
This was introduced with 9e882242c6193ae6f416f2d8d8db0d9126bd996b
which changed the return value of submit_bio_wait() to return != 0 on
error, but didn't update the caller accordingly.
Fixes: 9e882242c6 ("block: Add submit_bio_wait(), remove from md")
Reported-by: Bill Kuzeja <William.Kuzeja@stratus.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/md/raid1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 1cb7642c1ba9..479828ad2021 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2148,7 +2148,7 @@ static int narrow_write_error(struct r1bio *r1_bio, int i) md_trim_bio(wbio, sector - r1_bio->sector, sectors); wbio->bi_sector += rdev->data_offset; wbio->bi_bdev = rdev->bdev; - if (submit_bio_wait(WRITE, wbio) == 0) + if (submit_bio_wait(WRITE, wbio) < 0) /* failure! */ ok = rdev_set_badblocks(rdev, sector, sectors, 0) |