diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2022-01-20 17:29:36 +0800 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2022-04-12 16:11:49 -0700 |
| commit | 4a9800c81d2f34afb66b4b42e0330ae8298019a2 (patch) | |
| tree | 16bd4ab8d7cb8a3de607d87c9bb879b22bc7e963 | |
| parent | ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e (diff) | |
| download | lwn-4a9800c81d2f34afb66b4b42e0330ae8298019a2.tar.gz lwn-4a9800c81d2f34afb66b4b42e0330ae8298019a2.zip | |
lkdtm/bugs: Check for the NULL pointer after calling kmalloc
As the possible failure of the kmalloc(), the not_checked and checked
could be NULL pointer.
Therefore, it should be better to check it in order to avoid the
dereference of the NULL pointer.
Also, we need to kfree the 'not_checked' and 'checked' to avoid
the memory leak if fails.
And since it is just a test, it may directly return without error
number.
Fixes: ae2e1aad3e48 ("drivers/misc/lkdtm/bugs.c: add arithmetic overflow and array bounds checks")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220120092936.1874264-1-jiasheng@iscas.ac.cn
| -rw-r--r-- | drivers/misc/lkdtm/bugs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c index f21854ac5cc2..4f2808b2ca3c 100644 --- a/drivers/misc/lkdtm/bugs.c +++ b/drivers/misc/lkdtm/bugs.c @@ -327,6 +327,11 @@ void lkdtm_ARRAY_BOUNDS(void) not_checked = kmalloc(sizeof(*not_checked) * 2, GFP_KERNEL); checked = kmalloc(sizeof(*checked) * 2, GFP_KERNEL); + if (!not_checked || !checked) { + kfree(not_checked); + kfree(checked); + return; + } pr_info("Array access within bounds ...\n"); /* For both, touch all bytes in the actual member size. */ |