diff options
| author | Kumar Kartikeya Dwivedi <memxor@gmail.com> | 2021-08-26 17:39:10 +0530 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2021-08-26 12:09:20 -0700 |
| commit | 48b2e71c2e53263ebbb6798bbf208e191937e691 (patch) | |
| tree | 7bf0b4c520f9ed47aa30fc9f875bdf17b1bd10d7 | |
| parent | 3599bc5101b36d9ff88da17fe65b001aeadd9c62 (diff) | |
| download | lwn-48b2e71c2e53263ebbb6798bbf208e191937e691.tar.gz lwn-48b2e71c2e53263ebbb6798bbf208e191937e691.zip | |
samples: bpf: Fix uninitialized variable in xdp_redirect_cpu
While at it, also improve help output when CPU number is greater than
possible.
Fixes: e531a220cc59 ("samples: bpf: Convert xdp_redirect_cpu to XDP samples helper")
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210826120910.454081-1-memxor@gmail.com
| -rw-r--r-- | samples/bpf/xdp_redirect_cpu_user.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c index 631700aef69c..6e25fba64c72 100644 --- a/samples/bpf/xdp_redirect_cpu_user.c +++ b/samples/bpf/xdp_redirect_cpu_user.c @@ -141,7 +141,7 @@ static int create_cpu_entry(__u32 cpu, struct bpf_cpumap_val *value, static int mark_cpus_unavailable(void) { int ret, i, n_cpus = libbpf_num_possible_cpus(); - __u32 invalid_cpu; + __u32 invalid_cpu = n_cpus; for (i = 0; i < n_cpus; i++) { ret = bpf_map_update_elem(avail_fd, &i, @@ -449,8 +449,9 @@ int main(int argc, char **argv) add_cpu = strtoul(optarg, NULL, 0); if (add_cpu >= n_cpus) { fprintf(stderr, - "--cpu nr too large for cpumap err(%d):%s\n", + "--cpu nr too large for cpumap err (%d):%s\n", errno, strerror(errno)); + usage(argv, long_options, __doc__, mask, true, skel->obj); goto end_cpu; } cpu[added_cpus++] = add_cpu; |