summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2010-10-31 15:18:42 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-10-31 21:05:43 -0400
commit47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb (patch)
tree2255f8b182494f0af2681b94396c1212d8094955
parent50440c6dcccbf90ee3629407cb13ca09cab7d900 (diff)
downloadlwn-47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb.tar.gz
lwn-47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb.zip
Input: ir-keytable - fix uninitialized variable warning
We were forgetting to set up proper return value in success path causing ir_getkeycode() to fail intermittently: drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/media/IR/ir-keytable.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index 647d52b1a1b7..f60107c3b091 100644
--- a/drivers/media/IR/ir-keytable.c
+++ b/drivers/media/IR/ir-keytable.c
@@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev,
ke->len = sizeof(entry->scancode);
memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode));
+ retval = 0;
+
out:
spin_unlock_irqrestore(&rc_tab->lock, flags);
return retval;