diff options
| author | NeilBrown <neilb@suse.de> | 2015-06-12 19:46:44 +1000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-06-22 17:03:35 -0700 |
| commit | 4715a2ff078ecdf6b195bce7f5ea537e31a5e552 (patch) | |
| tree | acc51e2db953fb5fb0f33c7419bbdc9e24aad9ca | |
| parent | ad48fa9ae00009037975d535245dc8a63e997e4f (diff) | |
| download | lwn-4715a2ff078ecdf6b195bce7f5ea537e31a5e552.tar.gz lwn-4715a2ff078ecdf6b195bce7f5ea537e31a5e552.zip | |
md: don't return 0 from array_state_store
commit c008f1d356277a5b7561040596a073d87e56b0c8 upstream.
Returning zero from a 'store' function is bad.
The return value should be either len length of the string
or an error.
So use 'len' if 'err' is zero.
Fixes: 6791875e2e53 ("md: make reconfig_mutex optional for writes to md sysfs files.")
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/md/md.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 5333d6167ca6..b7bf8ee857fa 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3765,7 +3765,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len) err = -EBUSY; } spin_unlock(&mddev->lock); - return err; + return err ?: len; } err = mddev_lock(mddev); if (err) |