diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2016-05-16 17:28:16 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-07-12 10:02:01 +0200 |
| commit | 461dbb3855305ad7e841799ef573d6fc2abf6ed3 (patch) | |
| tree | a7c4e2c8af3fc8926ef5a5af4c4485308960f029 | |
| parent | b67568e47ba9844d18da561b7081e2e5354abb8d (diff) | |
| download | lwn-461dbb3855305ad7e841799ef573d6fc2abf6ed3.tar.gz lwn-461dbb3855305ad7e841799ef573d6fc2abf6ed3.zip | |
netlink: Fix dump skb leak/double free
[ Upstream commit 92964c79b357efd980812c4de5c1fd2ec8bb5520 ]
When we free cb->skb after a dump, we do it after releasing the
lock. This means that a new dump could have started in the time
being and we'll end up freeing their skb instead of ours.
This patch saves the skb and module before we unlock so we free
the right memory.
Fixes: 16b304f3404f ("netlink: Eliminate kmalloc in netlink dump operation.")
Reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | net/netlink/af_netlink.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 10805856dfba..bb04abe72d76 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2658,6 +2658,7 @@ static int netlink_dump(struct sock *sk) struct netlink_callback *cb; struct sk_buff *skb = NULL; struct nlmsghdr *nlh; + struct module *module; int len, err = -ENOBUFS; int alloc_size; @@ -2707,9 +2708,11 @@ static int netlink_dump(struct sock *sk) cb->done(cb); nlk->cb_running = false; + module = cb->module; + skb = cb->skb; mutex_unlock(nlk->cb_mutex); - module_put(cb->module); - consume_skb(cb->skb); + module_put(module); + consume_skb(skb); return 0; errout_skb: |