diff options
| author | Daniel Lezcano <daniel.lezcano@linaro.org> | 2016-04-19 15:43:02 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-05-11 11:21:22 +0200 |
| commit | 42ff5fc8661040f37a67a4a95c231f6765d6f59c (patch) | |
| tree | 55f59237e4ef8a9b59ded7d21cd250816c7959fa | |
| parent | fbc310e9c553412ebe72c14e5a7bb9807a3d1109 (diff) | |
| download | lwn-42ff5fc8661040f37a67a4a95c231f6765d6f59c.tar.gz lwn-42ff5fc8661040f37a67a4a95c231f6765d6f59c.zip | |
clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test
commit 16eeed7e5558a3dcf30f75526a896b2632f299f9 upstream.
Commit 0881841f7e78 introduced a regression by inverting a test check
after calling clocksource_mmio_init(). That results on the system to
hang at boot time.
Fix it by inverting the test again.
Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init")
Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/clocksource/tango_xtal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c index 2bcecafdeaea..c407c47a3232 100644 --- a/drivers/clocksource/tango_xtal.c +++ b/drivers/clocksource/tango_xtal.c @@ -42,7 +42,7 @@ static void __init tango_clocksource_init(struct device_node *np) ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350, 32, clocksource_mmio_readl_up); - if (!ret) { + if (ret) { pr_err("%s: registration failed\n", np->full_name); return; } |