diff options
author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2024-07-29 12:42:22 +0200 |
---|---|---|
committer | Xu Yilun <yilun.xu@linux.intel.com> | 2024-08-14 23:57:07 +0800 |
commit | 4168ced7e02bef642a3641aec3b81107a5996707 (patch) | |
tree | db1628a04483c45f28bd09fd8ac3079b0b05114b | |
parent | d783ed2f5fe7850fb7f6296ae267e2efcf877319 (diff) | |
download | lwn-4168ced7e02bef642a3641aec3b81107a5996707.tar.gz lwn-4168ced7e02bef642a3641aec3b81107a5996707.zip |
fpga: socfpga: Rename 'timeout' variable as 'time_left'
There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of
wait_for_completion_interruptible_timeout() causing patterns like:
timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.
Fix to the proper variable type 'long' while here.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20240729104319.2658-1-wsa+renesas@sang-engineering.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
-rw-r--r-- | drivers/fpga/socfpga.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 723ea0ad3f09..b08b4bb8f650 100644 --- a/drivers/fpga/socfpga.c +++ b/drivers/fpga/socfpga.c @@ -301,16 +301,17 @@ static irqreturn_t socfpga_fpga_isr(int irq, void *dev_id) static int socfpga_fpga_wait_for_config_done(struct socfpga_fpga_priv *priv) { - int timeout, ret = 0; + int ret = 0; + long time_left; socfpga_fpga_disable_irqs(priv); init_completion(&priv->status_complete); socfpga_fpga_enable_irqs(priv, SOCFPGA_FPGMGR_MON_CONF_DONE); - timeout = wait_for_completion_interruptible_timeout( + time_left = wait_for_completion_interruptible_timeout( &priv->status_complete, msecs_to_jiffies(10)); - if (timeout == 0) + if (time_left == 0) ret = -ETIMEDOUT; socfpga_fpga_disable_irqs(priv); |