diff options
| author | Joseph Qi <joseph.qi@linux.alibaba.com> | 2021-02-23 09:55:28 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-03-02 11:25:38 -0700 |
| commit | 4168a8d27ed3a00f160e7f885c956f060d2a0741 (patch) | |
| tree | 8189c7bea8cf69b4f8d8c155cc446691e01bb84e | |
| parent | e4ef09e512940846fad77b1934065c166870b85a (diff) | |
| download | lwn-4168a8d27ed3a00f160e7f885c956f060d2a0741.tar.gz lwn-4168a8d27ed3a00f160e7f885c956f060d2a0741.zip | |
block/bfq: update comments and default value in docs for fifo_expire
Correct the comments since bfq_fifo_expire[0] is for async request,
while bfq_fifo_expire[1] is for sync request.
Also update docs, according the source code, the default
fifo_expire_async is 250ms, and fifo_expire_sync is 125ms.
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | Documentation/block/bfq-iosched.rst | 4 | ||||
| -rw-r--r-- | block/bfq-iosched.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst index 19d4d1570cee..66c5a4e54130 100644 --- a/Documentation/block/bfq-iosched.rst +++ b/Documentation/block/bfq-iosched.rst @@ -430,13 +430,13 @@ fifo_expire_async ----------------- This parameter is used to set the timeout of asynchronous requests. Default -value of this is 248ms. +value of this is 250ms. fifo_expire_sync ---------------- This parameter is used to set the timeout of synchronous requests. Default -value of this is 124ms. In case to favor synchronous requests over asynchronous +value of this is 125ms. In case to favor synchronous requests over asynchronous one, this value should be decreased relative to fifo_expire_async. low_latency diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ec482e6641ff..95586137194e 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -162,7 +162,7 @@ BFQ_BFQQ_FNS(split_coop); BFQ_BFQQ_FNS(softrt_update); #undef BFQ_BFQQ_FNS \ -/* Expiration time of sync (0) and async (1) requests, in ns. */ +/* Expiration time of async (0) and sync (1) requests, in ns. */ static const u64 bfq_fifo_expire[2] = { NSEC_PER_SEC / 4, NSEC_PER_SEC / 8 }; /* Maximum backwards seek (magic number lifted from CFQ), in KiB. */ |