diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-06-16 20:25:54 +0000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-07-11 13:33:55 +0100 |
| commit | 3f5ec1a1dc36df4e56656e21ad4a02048bc101b9 (patch) | |
| tree | b10054a3b3d849e768f5c5874d9d0480b788d501 | |
| parent | 167dc42e69226e50b97b44f0777a387ab1a932cc (diff) | |
| download | lwn-3f5ec1a1dc36df4e56656e21ad4a02048bc101b9.tar.gz lwn-3f5ec1a1dc36df4e56656e21ad4a02048bc101b9.zip | |
target: Fix left-over se_lun->lun_sep pointer OOPs
commit 83ff42fcce070801a3aa1cd6a3269d7426271a8d upstream.
This patch fixes a left-over se_lun->lun_sep pointer OOPs when one
of the /sys/kernel/config/target/$FABRIC/$WWPN/$TPGT/lun/$LUN/alua*
attributes is accessed after the $DEVICE symlink has been removed.
To address this bug, go ahead and clear se_lun->lun_sep memory in
core_dev_unexport(), so that the existing checks for show/store
ALUA attributes in target_core_fabric_configfs.c work as expected.
Reported-by: Sebastian Herbszt <herbszt@gmx.de>
Tested-by: Sebastian Herbszt <herbszt@gmx.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/target/target_core_device.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 5def3593e872..69939613e8d6 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -646,6 +646,7 @@ void core_dev_unexport( spin_unlock(&dev->se_port_lock); se_dev_stop(dev); + lun->lun_sep = NULL; lun->lun_se_dev = NULL; } |