diff options
| author | Luo Jiaxing <luojiaxing@huawei.com> | 2020-07-22 17:04:02 +0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-07-24 22:09:55 -0400 |
| commit | 3a243c2c35002f51ff1e62a4337cffe39b17f3d6 (patch) | |
| tree | ee69632a5c22a6c79fa72e7a010b323734c78f08 | |
| parent | e3d2bf6505ddd4d11226dc2ad2071981564a35db (diff) | |
| download | lwn-3a243c2c35002f51ff1e62a4337cffe39b17f3d6.tar.gz lwn-3a243c2c35002f51ff1e62a4337cffe39b17f3d6.zip | |
scsi: libsas: Remove postreset from sas_sata_ops
sas_sata_ops uses ata_std_postreset as .postreset callback. However,
ata_std_postreset() calls sata_scr_read()/sata_scr_write() which need to
access the ATA SCR register. This register not available in the libsas case
and the functions always return -EOPNOTSUPP.
Drop the .postreset callback.
Link: https://lore.kernel.org/r/1595408643-63011-2-git-send-email-luojiaxing@huawei.com
Reviewed-by: John Garry <john.garry@huawei.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/libsas/sas_ata.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 5d716d388707..a7d16d285b86 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -510,7 +510,6 @@ void sas_ata_end_eh(struct ata_port *ap) static struct ata_port_operations sas_sata_ops = { .prereset = ata_std_prereset, .hardreset = sas_ata_hard_reset, - .postreset = ata_std_postreset, .error_handler = ata_std_error_handler, .post_internal_cmd = sas_ata_post_internal, .qc_defer = ata_std_qc_defer, |