diff options
| author | Yazen Ghannam <yazen.ghannam@amd.com> | 2024-10-21 15:21:58 +0000 |
|---|---|---|
| committer | Borislav Petkov (AMD) <bp@alien8.de> | 2024-10-22 18:55:57 +0200 |
| commit | 233679b58c0bfe7bafeb6e048b90af08bb9e7fc1 (patch) | |
| tree | 1a1b671f3abdde769ee6cf6cf45d90d6343241b3 | |
| parent | e4196757547444f7c4c156e56ea9d44612e97cbf (diff) | |
| download | lwn-233679b58c0bfe7bafeb6e048b90af08bb9e7fc1.tar.gz lwn-233679b58c0bfe7bafeb6e048b90af08bb9e7fc1.zip | |
RAS/AMD/ATL: Add debug prints for DF register reads
The ATL will fail early if the DF register access fails due to missing
PCI IDs in the amd_nb code. There aren't any clear indicators on why the
ATL will fail to load in this case.
Add a couple of debug print statements to highlight reasons for failure.
A common scenario is missing support for new hardware. If the ATL fails
to load on a system, and there is interest to support it, then dynamic
debugging can be enabled to help find the cause for failure. If there is
no interest in supporting ATL on a new system, then these failures will
be silent.
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20241021152158.2525669-1-yazen.ghannam@amd.com
| -rw-r--r-- | drivers/ras/amd/atl/access.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/ras/amd/atl/access.c b/drivers/ras/amd/atl/access.c index ee4661ed28ba..c2334f8f9add 100644 --- a/drivers/ras/amd/atl/access.c +++ b/drivers/ras/amd/atl/access.c @@ -70,12 +70,16 @@ static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *l u32 ficaa = 0; node = get_accessible_node(node); - if (node >= amd_nb_num()) + if (node >= amd_nb_num()) { + pr_debug("Node %u is out of bounds\n", node); goto out; + } F4 = node_to_amd_nb(node)->link; - if (!F4) + if (!F4) { + pr_debug("DF function 4 not found\n"); goto out; + } /* Enable instance-specific access. */ if (instance_id != DF_BROADCAST) { |