diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2026-05-29 16:39:56 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2026-05-29 16:39:56 -0700 |
| commit | 230ff934f744a4c2e4b74893ccf6734f6556db90 (patch) | |
| tree | 0479ce6ed10b277e82f1f0509a3781dfa2ea8498 | |
| parent | f3be0c984ecbcb82b0bec408022c4ef738cb3843 (diff) | |
| parent | 006c66d1d52f1905e6ccfb615cf27235e4e6e745 (diff) | |
| download | lwn-230ff934f744a4c2e4b74893ccf6734f6556db90.tar.gz lwn-230ff934f744a4c2e4b74893ccf6734f6556db90.zip | |
Merge tag 'regmap-fix-v7.1-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
Pull regmap fix from Mark Brown:
"Some other fixing in an API user turned up the fact that we weren't
correctly applying cache only mode to volatile registers in
regmap_update_bits(), causing us to try to access hardware that was
powered off or otherwise not in a state to accept I/O. This fix
returns an error instead, avoiding more serious consequences"
* tag 'regmap-fix-v7.1-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
regmap: reject volatile update_bits() in cache-only mode
| -rw-r--r-- | drivers/base/regmap/regmap.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index b2b26f07f4e3..e6e022b02637 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -3257,6 +3257,9 @@ static int _regmap_update_bits(struct regmap *map, unsigned int reg, *change = false; if (regmap_volatile(map, reg) && map->reg_update_bits) { + if (map->cache_only) + return -EBUSY; + reg = regmap_reg_addr(map, reg); ret = map->reg_update_bits(map->bus_context, reg, mask, val); if (ret == 0 && change) |