diff options
| author | Stanislaw Gruszka <sgruszka@redhat.com> | 2014-02-04 09:07:09 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-20 11:06:11 -0800 |
| commit | 1fc42b84b45d4a58641821c3c0b601565523ad7d (patch) | |
| tree | f4b2a1b8f58abe0ee2a84c446359f9873bbbf15d | |
| parent | c2b570f3e4c62ca9fa82ef4e8e4a2bcb6ca4de8b (diff) | |
| download | lwn-1fc42b84b45d4a58641821c3c0b601565523ad7d.tar.gz lwn-1fc42b84b45d4a58641821c3c0b601565523ad7d.zip | |
pinctrl: protect pinctrl_list add
commit 7b320cb1ed2dbd2c5f2a778197baf76fd6bf545a upstream.
We have few fedora bug reports about list corruption on pinctrl,
for example:
https://bugzilla.redhat.com/show_bug.cgi?id=1051918
Most likely corruption happen due lack of protection of pinctrl_list
when adding new nodes to it. Patch corrects that.
Fixes: 42fed7ba44e ("pinctrl: move subsystem mutex to pinctrl_dev struct")
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/pinctrl/core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 5327f35d9b5c..bb7ee9cb00b1 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -807,7 +807,9 @@ static struct pinctrl *create_pinctrl(struct device *dev) kref_init(&p->users); /* Add the pinctrl handle to the global list */ + mutex_lock(&pinctrl_list_mutex); list_add_tail(&p->node, &pinctrl_list); + mutex_unlock(&pinctrl_list_mutex); return p; } |