diff options
| author | Helge Deller <deller@gmx.de> | 2022-06-07 12:57:58 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2022-06-07 13:01:17 +0200 |
| commit | 1d0811b03eb30b2f0793acaa96c6ce90b8b9c87a (patch) | |
| tree | 611de7a3d616ebb6537129268fa4d32b69463d2e | |
| parent | f2906aa863381afb0015a9eb7fefad885d4e5a56 (diff) | |
| download | lwn-1d0811b03eb30b2f0793acaa96c6ce90b8b9c87a.tar.gz lwn-1d0811b03eb30b2f0793acaa96c6ce90b8b9c87a.zip | |
parisc/stifb: Fix fb_is_primary_device() only available with CONFIG_FB_STI
Fix this build error noticed by the kernel test robot:
drivers/video/console/sticore.c:1132:5: error: redefinition of 'fb_is_primary_device'
arch/parisc/include/asm/fb.h:18:19: note: previous definition of 'fb_is_primary_device'
Signed-off-by: Helge Deller <deller@gmx.de>
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org # v5.10+
| -rw-r--r-- | arch/parisc/include/asm/fb.h | 2 | ||||
| -rw-r--r-- | drivers/video/console/sticore.c | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/arch/parisc/include/asm/fb.h b/arch/parisc/include/asm/fb.h index d63a2acb91f2..55d29c4f716e 100644 --- a/arch/parisc/include/asm/fb.h +++ b/arch/parisc/include/asm/fb.h @@ -12,7 +12,7 @@ static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, pgprot_val(vma->vm_page_prot) |= _PAGE_NO_CACHE; } -#if defined(CONFIG_STI_CONSOLE) || defined(CONFIG_FB_STI) +#if defined(CONFIG_FB_STI) int fb_is_primary_device(struct fb_info *info); #else static inline int fb_is_primary_device(struct fb_info *info) diff --git a/drivers/video/console/sticore.c b/drivers/video/console/sticore.c index fa23bf0247b0..bd4dc97d4d34 100644 --- a/drivers/video/console/sticore.c +++ b/drivers/video/console/sticore.c @@ -1148,6 +1148,7 @@ int sti_call(const struct sti_struct *sti, unsigned long func, return ret; } +#if defined(CONFIG_FB_STI) /* check if given fb_info is the primary device */ int fb_is_primary_device(struct fb_info *info) { @@ -1163,6 +1164,7 @@ int fb_is_primary_device(struct fb_info *info) return (sti->info == info); } EXPORT_SYMBOL(fb_is_primary_device); +#endif MODULE_AUTHOR("Philipp Rumpf, Helge Deller, Thomas Bogendoerfer"); MODULE_DESCRIPTION("Core STI driver for HP's NGLE series graphics cards in HP PARISC machines"); |