diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2016-08-12 01:05:09 +0300 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2016-09-12 14:53:17 -0400 |
| commit | 178bc9085d938641a1d02dba2a3b0b4f8ecf79e9 (patch) | |
| tree | 27f1c281b13a8c0227b5e34873d1c90ba57e786e | |
| parent | a1147c771a69625aaea70924cd7128ba35a2a74c (diff) | |
| download | lwn-178bc9085d938641a1d02dba2a3b0b4f8ecf79e9.tar.gz lwn-178bc9085d938641a1d02dba2a3b0b4f8ecf79e9.zip | |
USB: serial: mos7840: fix non-atomic allocation in write path
[ Upstream commit 3b7c7e52efda0d4640060de747768360ba70a7c0 ]
There is an allocation with GFP_KERNEL flag in mos7840_write(),
while it may be called from interrupt context.
Follow-up for commit 191252837626 ("USB: kobil_sct: fix non-atomic
allocation in write path")
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 3d88eefdf1d1..0b547d9e2aeb 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -1369,8 +1369,8 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port, } if (urb->transfer_buffer == NULL) { - urb->transfer_buffer = - kmalloc(URB_TRANSFER_BUFFER_SIZE, GFP_KERNEL); + urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE, + GFP_ATOMIC); if (!urb->transfer_buffer) goto exit; } |