diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2024-04-22 09:48:14 -0700 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2024-04-23 16:55:14 -0700 |
| commit | 13db7007892694c891fc37feccbd2ac8f227af78 (patch) | |
| tree | 19926adf99915250c41806523046d1aac4413db6 | |
| parent | 65a1fb7a11291f361d36e6ebf3bb5e60e9ca8d13 (diff) | |
| download | lwn-13db7007892694c891fc37feccbd2ac8f227af78.tar.gz lwn-13db7007892694c891fc37feccbd2ac8f227af78.zip | |
xfs: remove pointless unlocked assertion
Remove this assertion about the inode not having an attr fork from
xfs_bmap_add_attrfork because the function handles that case just fine.
Weirder still, the function actually /requires/ the caller not to hold
the ILOCK, which means that its accesses are not stabilized.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | fs/xfs/libxfs/xfs_bmap.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 8a1446e025e0..1f528cf2d906 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -1041,8 +1041,6 @@ xfs_bmap_add_attrfork( int logflags; /* logging flags */ int error; /* error return value */ - ASSERT(xfs_inode_has_attr_fork(ip) == 0); - mp = ip->i_mount; ASSERT(!XFS_NOT_DQATTACHED(mp, ip)); |