diff options
| author | Jonathan Corbet <corbet@lwn.net> | 2008-05-15 11:24:23 -0600 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2008-06-20 14:05:48 -0600 |
| commit | 12ead6b098b65dd21d3ed4fcccf20025dbe86cc2 (patch) | |
| tree | a45d63c7e0d2c60949b6ffe5cbc19c2b38d20968 | |
| parent | 2d863e92ec1b1deb8167d7f5266f754f258e876a (diff) | |
| download | lwn-12ead6b098b65dd21d3ed4fcccf20025dbe86cc2.tar.gz lwn-12ead6b098b65dd21d3ed4fcccf20025dbe86cc2.zip | |
mbcs: cdev lock_kernel() pushdown
This driver would appear to have no internal locking at all.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
| -rw-r--r-- | drivers/char/mbcs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c index f4716ad7348a..acd8e9ed474a 100644 --- a/drivers/char/mbcs.c +++ b/drivers/char/mbcs.c @@ -24,6 +24,7 @@ #include <linux/mm.h> #include <linux/uio.h> #include <linux/mutex.h> +#include <linux/smp_lock.h> #include <asm/io.h> #include <asm/uaccess.h> #include <asm/system.h> @@ -382,15 +383,19 @@ static int mbcs_open(struct inode *ip, struct file *fp) struct mbcs_soft *soft; int minor; + lock_kernel(); minor = iminor(ip); + /* Nothing protects access to this list... */ list_for_each_entry(soft, &soft_list, list) { if (soft->nasid == minor) { fp->private_data = soft->cxdev; + unlock_kernel(); return 0; } } + unlock_kernel(); return -ENODEV; } |