diff options
| author | Zhihao Cheng <chengzhihao1@huawei.com> | 2020-08-28 11:32:50 +0800 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2020-09-17 22:56:19 +0200 |
| commit | 121b8fcbf98892d5f26d8326a00d09e4cdb76369 (patch) | |
| tree | ebc8a6752f9b7393ae88d6a7f41f08338b4ac1c2 | |
| parent | dd7db149bcd914db8fdeb19cd5597c0740121bc7 (diff) | |
| download | lwn-121b8fcbf98892d5f26d8326a00d09e4cdb76369.tar.gz lwn-121b8fcbf98892d5f26d8326a00d09e4cdb76369.zip | |
ubifs: setflags: Don't show error message when vfs_ioc_setflags_prepare() fails
Following process will trigger ubifs_err:
1. useradd -m freg (Under root)
2. cd /home/freg && mkdir mp (Under freg)
3. mount -t ubifs /dev/ubi0_0 /home/freg/mp (Under root)
4. cd /home/freg && echo 123 > mp/a (Under root)
5. cd mp && chown freg a && chgrp freg a && chmod 777 a (Under root)
6. chattr +i a (Under freg)
UBIFS error (ubi0:0 pid 1723): ubifs_ioctl [ubifs]: can't modify inode
65 attributes
chattr: Operation not permitted while setting flags on a
This is not an UBIFS problem, it was caused by task priviliage checking
on file operations. Remove error message printing from kernel just like
other filesystems (eg. ext4), since we already have enough information
from userspace tools.
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | fs/ubifs/ioctl.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c index 3df9be2c684c..4363d85a3fd4 100644 --- a/fs/ubifs/ioctl.c +++ b/fs/ubifs/ioctl.c @@ -134,7 +134,6 @@ static int setflags(struct inode *inode, int flags) return err; out_unlock: - ubifs_err(c, "can't modify inode %lu attributes", inode->i_ino); mutex_unlock(&ui->ui_mutex); ubifs_release_budget(c, &req); return err; |