diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-07-21 11:25:27 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-23 18:01:08 -0700 |
| commit | 0c9cd395faca5ccf549e2bcb6b09086962c112b0 (patch) | |
| tree | bcad2f9eb8a72ac8dae16310614362469ac20f40 | |
| parent | ffe8553f8871dabf61d49e7f97a2c6cbc7dc23cb (diff) | |
| download | lwn-0c9cd395faca5ccf549e2bcb6b09086962c112b0.tar.gz lwn-0c9cd395faca5ccf549e2bcb6b09086962c112b0.zip | |
net: move xtsonic's probe function to .devinit.text
A pointer to xtsonic_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Chris Zankel <chris@zankel.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/xtsonic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/xtsonic.c b/drivers/net/xtsonic.c index 5a4ad156f63e..0c44135c0b1f 100644 --- a/drivers/net/xtsonic.c +++ b/drivers/net/xtsonic.c @@ -239,7 +239,7 @@ out: * Actually probing is superfluous but we're paranoid. */ -int __init xtsonic_probe(struct platform_device *pdev) +int __devinit xtsonic_probe(struct platform_device *pdev) { struct net_device *dev; struct sonic_local *lp; |