diff options
| author | Kamil Krawczyk <kamil.krawczyk@intel.com> | 2013-12-18 13:45:46 +0000 |
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2014-01-07 21:50:12 -0800 |
| commit | 071b8de9820fb622c1fd29775f3a47b99db312ad (patch) | |
| tree | a0381bd4ad353596fae14854022ede6bbd3f4de0 | |
| parent | c354229fc0f2c441aad7506dc4748cc9e9675767 (diff) | |
| download | lwn-071b8de9820fb622c1fd29775f3a47b99db312ad.tar.gz lwn-071b8de9820fb622c1fd29775f3a47b99db312ad.zip | |
i40e: remove redundant AQ enable
The admin queue length register is updated in
config_a<sq|rq>_regs functions. We should not update it again,
as we will trigger firmware to init the AQ again. In this case
firmware will lose the information about the AQ Rx tail position
and will see Rx queue as full (no free desc for FW to use).
Signed-off-by: Kamil Krawczyk <kamil.krawczyk@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_adminq.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c index 18a768f39d46..c87dc15372c5 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c @@ -957,20 +957,14 @@ clean_arq_element_out: static void i40e_resume_aq(struct i40e_hw *hw) { - u32 reg = 0; - /* Registers are reset after PF reset */ hw->aq.asq.next_to_use = 0; hw->aq.asq.next_to_clean = 0; i40e_config_asq_regs(hw); - reg = hw->aq.num_asq_entries | I40E_PF_ATQLEN_ATQENABLE_MASK; - wr32(hw, hw->aq.asq.len, reg); hw->aq.arq.next_to_use = 0; hw->aq.arq.next_to_clean = 0; i40e_config_arq_regs(hw); - reg = hw->aq.num_arq_entries | I40E_PF_ATQLEN_ATQENABLE_MASK; - wr32(hw, hw->aq.arq.len, reg); } |