diff options
| author | Nikolay Borisov <kernel@kyup.com> | 2015-12-17 18:03:35 +0200 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-02-12 08:58:10 +0100 |
| commit | 021cc4c804dd34b3a4fca8175506bb8be380242d (patch) | |
| tree | 92758d3c386acb895e05c22238a37a83da8f8a70 | |
| parent | d43afc4a7e793dbe84b16e2b35e2522150adc260 (diff) | |
| download | lwn-021cc4c804dd34b3a4fca8175506bb8be380242d.tar.gz lwn-021cc4c804dd34b3a4fca8175506bb8be380242d.zip | |
dm thin: fix race condition when destroying thin pool workqueue
commit 18d03e8c25f173f4107a40d0b8c24defb6ed69f3 upstream.
When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running. This can cause the work item to
requeue itself on an already destroyed workqueue. Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.
Fixes: 905e51b39a555 ("dm thin: commit outstanding data every second")
Fixes: 85ad643b7e7e5 ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/md/dm-thin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 5ff934102f30..d14d1c1fff8b 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -2331,7 +2331,7 @@ static void pool_postsuspend(struct dm_target *ti) struct pool_c *pt = ti->private; struct pool *pool = pt->pool; - cancel_delayed_work(&pool->waker); + cancel_delayed_work_sync(&pool->waker); flush_workqueue(pool->wq); (void) commit(pool); } |