diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-05-28 07:51:26 -0400 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2021-11-05 14:40:25 +0000 |
| commit | 002be81140075e17a1ebd5c3c55e356fbab0ddad (patch) | |
| tree | 4961af71f348afe4e10a5c0a6ee8832c2a9f9046 | |
| parent | ddb1ada416fd3db44642b3bfaee5fe5bb3304721 (diff) | |
| download | lwn-002be81140075e17a1ebd5c3c55e356fbab0ddad.tar.gz lwn-002be81140075e17a1ebd5c3c55e356fbab0ddad.zip | |
mfd: core: Add missing of_node_put for loop iteration
Early exits from for_each_child_of_node() should decrement the
node reference counter. Reported by Coccinelle:
drivers/mfd/mfd-core.c:197:2-24: WARNING:
Function "for_each_child_of_node" should have of_node_put() before goto around lines 209.
Fixes: c94bb233a9fe ("mfd: Make MFD core code Device Tree and IRQ domain aware")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210528115126.18370-1-krzysztof.kozlowski@canonical.com
| -rw-r--r-- | drivers/mfd/mfd-core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 79f5c6a18815..684a011a6396 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -198,6 +198,7 @@ static int mfd_add_device(struct device *parent, int id, if (of_device_is_compatible(np, cell->of_compatible)) { /* Ignore 'disabled' devices error free */ if (!of_device_is_available(np)) { + of_node_put(np); ret = 0; goto fail_alias; } @@ -205,6 +206,7 @@ static int mfd_add_device(struct device *parent, int id, ret = mfd_match_of_node_to_dev(pdev, np, cell); if (ret == -EAGAIN) continue; + of_node_put(np); if (ret) goto fail_alias; |