1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
|
// SPDX-License-Identifier: GPL-2.0
#include <pthread.h>
#include <bpf/btf.h>
#include <test_progs.h>
/*
* Only a page is pinned to kernel, so the maximum amount of dynamic data
* allowed is page_size - sizeof(struct tld_data_u) - static TLD fields.
*/
#define TLD_DYN_DATA_SIZE_MAX (getpagesize() - sizeof(struct tld_data_u) - 8)
#define TLD_FREE_DATA_ON_THREAD_EXIT
#define TLD_DYN_DATA_SIZE TLD_DYN_DATA_SIZE_MAX
#include "task_local_data.h"
struct test_tld_struct {
__u64 a;
__u64 b;
__u64 c;
__u64 d;
};
#include "test_task_local_data.skel.h"
TLD_DEFINE_KEY(value0_key, "value0", sizeof(int));
/*
* Reset task local data between subtests by clearing metadata other
* than the statically defined value0. This is safe as subtests run
* sequentially. Users of task local data library should not touch
* library internal.
*/
static void reset_tld(__u16 dyn_data_size)
{
if (tld_meta_p) {
/* Remove TLDs created by tld_create_key() */
tld_meta_p->cnt = 1;
tld_meta_p->size = dyn_data_size + 8;
memset(&tld_meta_p->metadata[1], 0,
(TLD_MAX_DATA_CNT - 1) * sizeof(struct tld_metadata));
}
}
/* Serialize access to bpf program's global variables */
static pthread_mutex_t global_mutex;
static tld_key_t *tld_keys;
#define TEST_BASIC_THREAD_NUM 32
void *test_task_local_data_basic_thread(void *arg)
{
LIBBPF_OPTS(bpf_test_run_opts, opts);
struct test_task_local_data *skel = (struct test_task_local_data *)arg;
int fd, err, tid, *value0, *value1;
struct test_tld_struct *value2;
fd = bpf_map__fd(skel->maps.tld_data_map);
value0 = tld_get_data(fd, value0_key);
if (!ASSERT_OK_PTR(value0, "tld_get_data"))
goto out;
value1 = tld_get_data(fd, tld_keys[1]);
if (!ASSERT_OK_PTR(value1, "tld_get_data"))
goto out;
value2 = tld_get_data(fd, tld_keys[2]);
if (!ASSERT_OK_PTR(value2, "tld_get_data"))
goto out;
tid = sys_gettid();
*value0 = tid + 0;
*value1 = tid + 1;
value2->a = tid + 2;
value2->b = tid + 3;
value2->c = tid + 4;
value2->d = tid + 5;
pthread_mutex_lock(&global_mutex);
/* Run task_main that read task local data and save to global variables */
err = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.task_main), &opts);
ASSERT_OK(err, "run task_main");
ASSERT_OK(opts.retval, "task_main retval");
ASSERT_EQ(skel->bss->test_value0, tid + 0, "tld_get_data value0");
ASSERT_EQ(skel->bss->test_value1, tid + 1, "tld_get_data value1");
ASSERT_EQ(skel->bss->test_value2.a, tid + 2, "tld_get_data value2.a");
ASSERT_EQ(skel->bss->test_value2.b, tid + 3, "tld_get_data value2.b");
ASSERT_EQ(skel->bss->test_value2.c, tid + 4, "tld_get_data value2.c");
ASSERT_EQ(skel->bss->test_value2.d, tid + 5, "tld_get_data value2.d");
pthread_mutex_unlock(&global_mutex);
/* Make sure valueX are indeed local to threads */
ASSERT_EQ(*value0, tid + 0, "value0");
ASSERT_EQ(*value1, tid + 1, "value1");
ASSERT_EQ(value2->a, tid + 2, "value2.a");
ASSERT_EQ(value2->b, tid + 3, "value2.b");
ASSERT_EQ(value2->c, tid + 4, "value2.c");
ASSERT_EQ(value2->d, tid + 5, "value2.d");
*value0 = tid + 5;
*value1 = tid + 4;
value2->a = tid + 3;
value2->b = tid + 2;
value2->c = tid + 1;
value2->d = tid + 0;
/* Run task_main again */
pthread_mutex_lock(&global_mutex);
err = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.task_main), &opts);
ASSERT_OK(err, "run task_main");
ASSERT_OK(opts.retval, "task_main retval");
ASSERT_EQ(skel->bss->test_value0, tid + 5, "tld_get_data value0");
ASSERT_EQ(skel->bss->test_value1, tid + 4, "tld_get_data value1");
ASSERT_EQ(skel->bss->test_value2.a, tid + 3, "tld_get_data value2.a");
ASSERT_EQ(skel->bss->test_value2.b, tid + 2, "tld_get_data value2.b");
ASSERT_EQ(skel->bss->test_value2.c, tid + 1, "tld_get_data value2.c");
ASSERT_EQ(skel->bss->test_value2.d, tid + 0, "tld_get_data value2.d");
pthread_mutex_unlock(&global_mutex);
out:
pthread_exit(NULL);
}
static void test_task_local_data_basic(void)
{
struct test_task_local_data *skel;
pthread_t thread[TEST_BASIC_THREAD_NUM];
char dummy_key_name[TLD_NAME_LEN];
tld_key_t key;
int i, err;
reset_tld(TLD_DYN_DATA_SIZE_MAX);
ASSERT_OK(pthread_mutex_init(&global_mutex, NULL), "pthread_mutex_init");
skel = test_task_local_data__open_and_load();
if (!ASSERT_OK_PTR(skel, "skel_open_and_load"))
return;
tld_keys = calloc(TLD_MAX_DATA_CNT, sizeof(tld_key_t));
if (!ASSERT_OK_PTR(tld_keys, "calloc tld_keys"))
goto out;
ASSERT_FALSE(tld_key_is_err(value0_key), "TLD_DEFINE_KEY");
tld_keys[1] = tld_create_key("value1", sizeof(int));
ASSERT_FALSE(tld_key_is_err(tld_keys[1]), "tld_create_key");
tld_keys[2] = tld_create_key("value2", sizeof(struct test_tld_struct));
ASSERT_FALSE(tld_key_is_err(tld_keys[2]), "tld_create_key");
/*
* Shouldn't be able to store data exceed a page. Create a TLD just big
* enough to exceed a page. Data already contains struct tld_data_u,
* value0 and value1 of int type, and value 2 of struct test_tld_struct.
*/
key = tld_create_key("value_not_exist", TLD_PAGE_SIZE + 1 -
sizeof(struct tld_data_u) -
TLD_ROUND_UP(sizeof(int), 8) * 2 -
TLD_ROUND_UP(sizeof(struct test_tld_struct), 8));
ASSERT_EQ(tld_key_err_or_zero(key), -E2BIG, "tld_create_key");
key = tld_create_key("value2", sizeof(struct test_tld_struct));
ASSERT_EQ(tld_key_err_or_zero(key), -EEXIST, "tld_create_key");
/* Shouldn't be able to create the (TLD_MAX_DATA_CNT+1)-th TLD */
for (i = 3; i < TLD_MAX_DATA_CNT; i++) {
snprintf(dummy_key_name, TLD_NAME_LEN, "dummy_value%d", i);
tld_keys[i] = tld_create_key(dummy_key_name, sizeof(int));
ASSERT_FALSE(tld_key_is_err(tld_keys[i]), "tld_create_key");
}
key = tld_create_key("value_not_exist", sizeof(struct test_tld_struct));
ASSERT_EQ(tld_key_err_or_zero(key), -ENOSPC, "tld_create_key");
/* Access TLDs from multiple threads and check if they are thread-specific */
for (i = 0; i < TEST_BASIC_THREAD_NUM; i++) {
err = pthread_create(&thread[i], NULL, test_task_local_data_basic_thread, skel);
if (!ASSERT_OK(err, "pthread_create"))
goto out;
}
out:
for (i = 0; i < TEST_BASIC_THREAD_NUM; i++)
pthread_join(thread[i], NULL);
if (tld_keys) {
free(tld_keys);
tld_keys = NULL;
}
tld_free();
test_task_local_data__destroy(skel);
}
#define TEST_RACE_THREAD_NUM (TLD_MAX_DATA_CNT - 3)
void *test_task_local_data_race_thread(void *arg)
{
int err = 0, id = (intptr_t)arg;
char key_name[32];
tld_key_t key;
key = tld_create_key("value_not_exist", TLD_PAGE_SIZE + 1);
if (tld_key_err_or_zero(key) != -E2BIG) {
err = 1;
goto out;
}
/* Only one thread will succeed in creating value1 */
key = tld_create_key("value1", sizeof(int));
if (!tld_key_is_err(key))
tld_keys[1] = key;
/* Only one thread will succeed in creating value2 */
key = tld_create_key("value2", sizeof(struct test_tld_struct));
if (!tld_key_is_err(key))
tld_keys[2] = key;
snprintf(key_name, 32, "thread_%d", id);
tld_keys[id] = tld_create_key(key_name, sizeof(int));
if (tld_key_is_err(tld_keys[id]))
err = 2;
out:
return (void *)(intptr_t)err;
}
static void test_task_local_data_race(void)
{
LIBBPF_OPTS(bpf_test_run_opts, opts);
pthread_t thread[TEST_RACE_THREAD_NUM];
struct test_task_local_data *skel;
int fd, i, j, err, *data;
void *ret = NULL;
skel = test_task_local_data__open_and_load();
if (!ASSERT_OK_PTR(skel, "skel_open_and_load"))
return;
tld_keys = calloc(TLD_MAX_DATA_CNT, sizeof(tld_key_t));
if (!ASSERT_OK_PTR(tld_keys, "calloc tld_keys"))
goto out;
fd = bpf_map__fd(skel->maps.tld_data_map);
ASSERT_FALSE(tld_key_is_err(value0_key), "TLD_DEFINE_KEY");
tld_keys[0] = value0_key;
for (j = 0; j < 100; j++) {
reset_tld(TLD_DYN_DATA_SIZE_MAX);
for (i = 0; i < TEST_RACE_THREAD_NUM; i++) {
/*
* Try to make tld_create_key() race with each other. Call
* tld_create_key(), both valid and invalid, from different threads.
*/
err = pthread_create(&thread[i], NULL, test_task_local_data_race_thread,
(void *)(intptr_t)(i + 3));
if (CHECK_FAIL(err))
break;
}
/* Wait for all tld_create_key() to return */
for (i = 0; i < TEST_RACE_THREAD_NUM; i++) {
pthread_join(thread[i], &ret);
if (CHECK_FAIL(ret))
break;
}
/* Write a unique number to each TLD */
for (i = 0; i < TLD_MAX_DATA_CNT; i++) {
data = tld_get_data(fd, tld_keys[i]);
if (CHECK_FAIL(!data))
break;
*data = i;
}
/* Read TLDs and check the value to see if any address collides with another */
for (i = 0; i < TLD_MAX_DATA_CNT; i++) {
data = tld_get_data(fd, tld_keys[i]);
if (CHECK_FAIL(*data != i))
break;
}
/* Run task_main to make sure no invalid TLDs are added */
err = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.task_main), &opts);
ASSERT_OK(err, "run task_main");
ASSERT_OK(opts.retval, "task_main retval");
}
out:
if (tld_keys) {
free(tld_keys);
tld_keys = NULL;
}
tld_free();
test_task_local_data__destroy(skel);
}
static void test_task_local_data_dyn_size(__u16 dyn_data_size)
{
LIBBPF_OPTS(bpf_test_run_opts, opts);
struct test_task_local_data *skel;
int max_keys, i, err, fd, *data;
char name[TLD_NAME_LEN];
tld_key_t key;
reset_tld(dyn_data_size);
skel = test_task_local_data__open_and_load();
if (!ASSERT_OK_PTR(skel, "skel_open_and_load"))
return;
tld_keys = calloc(TLD_MAX_DATA_CNT, sizeof(tld_key_t));
if (!ASSERT_OK_PTR(tld_keys, "calloc tld_keys"))
goto out;
fd = bpf_map__fd(skel->maps.tld_data_map);
/* Create as many int-sized TLDs as the dynamic data size allows */
max_keys = dyn_data_size / TLD_ROUND_UP(sizeof(int), 8);
for (i = 0; i < max_keys; i++) {
snprintf(name, TLD_NAME_LEN, "value_%d", i);
tld_keys[i] = tld_create_key(name, sizeof(int));
if (!ASSERT_FALSE(tld_key_is_err(tld_keys[i]), "tld_create_key"))
goto out;
data = tld_get_data(fd, tld_keys[i]);
if (!ASSERT_OK_PTR(data, "tld_get_data"))
goto out;
*data = i;
}
/* The next key should fail with E2BIG */
key = tld_create_key("overflow", sizeof(int));
ASSERT_EQ(tld_key_err_or_zero(key), -E2BIG, "tld_create_key overflow");
/* Verify data for value_i do not overlap */
for (i = 0; i < max_keys; i++) {
data = tld_get_data(fd, tld_keys[i]);
if (!ASSERT_OK_PTR(data, "tld_get_data"))
goto out;
ASSERT_EQ(*data, i, "tld_get_data value_i");
}
/* Verify BPF side can still read the static key */
data = tld_get_data(fd, value0_key);
if (!ASSERT_OK_PTR(data, "tld_get_data value0"))
goto out;
*data = 0xdeadbeef;
err = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.task_main), &opts);
ASSERT_OK(err, "run task_main");
ASSERT_EQ(skel->bss->test_value0, 0xdeadbeef, "tld_get_data value0");
out:
if (tld_keys) {
free(tld_keys);
tld_keys = NULL;
}
tld_free();
test_task_local_data__destroy(skel);
}
void test_task_local_data(void)
{
if (test__start_subtest("task_local_data_basic"))
test_task_local_data_basic();
if (test__start_subtest("task_local_data_race"))
test_task_local_data_race();
if (test__start_subtest("task_local_data_dyn_size_small"))
test_task_local_data_dyn_size(64);
if (test__start_subtest("task_local_data_dyn_size_zero"))
test_task_local_data_dyn_size(0);
}
|