summaryrefslogtreecommitdiff
path: root/virt
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2023-12-08 13:46:48 -0500
committerPaolo Bonzini <pbonzini@redhat.com>2023-12-08 13:46:48 -0500
commit80583d0cfd8ff44d60a5fa76a6bf3c08eb67c328 (patch)
tree259800ea1082a602d06afbd852db91b8fb998fa4 /virt
parent849c1816436fe359e85587fba5b69ddd3a957b31 (diff)
downloadlwn-80583d0cfd8ff44d60a5fa76a6bf3c08eb67c328.tar.gz
lwn-80583d0cfd8ff44d60a5fa76a6bf3c08eb67c328.zip
KVM: guest-memfd: fix unused-function warning
With migration disabled, one function becomes unused: virt/kvm/guest_memfd.c:262:12: error: 'kvm_gmem_migrate_folio' defined but not used [-Werror=unused-function] 262 | static int kvm_gmem_migrate_folio(struct address_space *mapping, | ^~~~~~~~~~~~~~~~~~~~~~ Remove the #ifdef around the reference so that fallback_migrate_folio() is never used. The gmem implementation of the hook is trivial; since the gmem mapping is unmovable, the pages should not be migrated anyway. Fixes: a7800aa80ea4 ("KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory") Reported-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Sean Christopherson <seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'virt')
-rw-r--r--virt/kvm/guest_memfd.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
index b99272396119..c2e2371720a9 100644
--- a/virt/kvm/guest_memfd.c
+++ b/virt/kvm/guest_memfd.c
@@ -300,9 +300,7 @@ static int kvm_gmem_error_page(struct address_space *mapping, struct page *page)
static const struct address_space_operations kvm_gmem_aops = {
.dirty_folio = noop_dirty_folio,
-#ifdef CONFIG_MIGRATION
.migrate_folio = kvm_gmem_migrate_folio,
-#endif
.error_remove_page = kvm_gmem_error_page,
};