diff options
author | Avi Kivity <avi@redhat.com> | 2009-12-28 14:08:30 +0200 |
---|---|---|
committer | Marcelo Tosatti <mtosatti@redhat.com> | 2010-03-01 12:35:46 -0300 |
commit | 46a929bc15fcd48e1e0e770a44040a6949cae133 (patch) | |
tree | 5351d75586821e74d82c59f1e1cde10806a25237 /virt/kvm/ioapic.h | |
parent | f4c9e87c83a9f5bc1800db27dbb39e5cd1254c0a (diff) | |
download | lwn-46a929bc15fcd48e1e0e770a44040a6949cae133.tar.gz lwn-46a929bc15fcd48e1e0e770a44040a6949cae133.zip |
KVM: avoid taking ioapic mutex for non-ioapic EOIs
When the guest acknowledges an interrupt, it sends an EOI message to the local
apic, which broadcasts it to the ioapic. To handle the EOI, we need to take
the ioapic mutex.
On large guests, this causes a lot of contention on this mutex. Since large
guests usually don't route interrupts via the ioapic (they use msi instead),
this is completely unnecessary.
Avoid taking the mutex by introducing a handled_vectors bitmap. Before taking
the mutex, check if the ioapic was actually responsible for the acked vector.
If not, we can return early.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'virt/kvm/ioapic.h')
-rw-r--r-- | virt/kvm/ioapic.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/virt/kvm/ioapic.h b/virt/kvm/ioapic.h index 419c43b667ab..a505ce9054f3 100644 --- a/virt/kvm/ioapic.h +++ b/virt/kvm/ioapic.h @@ -46,6 +46,7 @@ struct kvm_ioapic { struct kvm *kvm; void (*ack_notifier)(void *opaque, int irq); struct mutex lock; + DECLARE_BITMAP(handled_vectors, 256); }; #ifdef DEBUG |