summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorWaiman Long <longman@redhat.com>2023-12-07 08:46:14 -0500
committerTejun Heo <tj@kernel.org>2023-12-07 12:54:59 -1000
commita7fb0423c201ba12815877a0b5a68a6a1710b23a (patch)
tree00c82ba90d21af7cf6efc50858d83d7756f91ca9 /tools
parent3232e7aad11e541da86bbb1fa5ea5737b30bd006 (diff)
downloadlwn-a7fb0423c201ba12815877a0b5a68a6a1710b23a.tar.gz
lwn-a7fb0423c201ba12815877a0b5a68a6a1710b23a.zip
cgroup: Move rcu_head up near the top of cgroup_root
Commit d23b5c577715 ("cgroup: Make operations on the cgroup root_list RCU safe") adds a new rcu_head to the cgroup_root structure and kvfree_rcu() for freeing the cgroup_root. The current implementation of kvfree_rcu(), however, has the limitation that the offset of the rcu_head structure within the larger data structure must be less than 4096 or the compilation will fail. See the macro definition of __is_kvfree_rcu_offset() in include/linux/rcupdate.h for more information. By putting rcu_head below the large cgroup structure, any change to the cgroup structure that makes it larger run the risk of causing build failure under certain configurations. Commit 77070eeb8821 ("cgroup: Avoid false cacheline sharing of read mostly rstat_cpu") happens to be the last straw that breaks it. Fix this problem by moving the rcu_head structure up before the cgroup structure. Fixes: d23b5c577715 ("cgroup: Make operations on the cgroup root_list RCU safe") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/lkml/20231207143806.114e0a74@canb.auug.org.au/ Signed-off-by: Waiman Long <longman@redhat.com> Acked-by: Yafang Shao <laoar.shao@gmail.com> Reviewed-by: Yosry Ahmed <yosryahmed@google.com> Reviewed-by: Michal Koutný <mkoutny@suse.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions